Empty Env/LFO tab in SF2 player

[midi-pascal]

Hi,

I followed the directives in the wiki and did all steps to pull my request.
But the Git repo says 'midi-pascal wants to merge 1 commit into LMMS:stable-0.4 from midi-pascal:stable-0.4'
I'm a bit worried by the 'stable-0.4'
Did I failed somewhere in the process?
Let me know: I'm willing to learn

Thanks to you all, I fill welcome

[diiz]

No no, you did everything right... our branch name is just badly outdated

Should probably bug Toby about it at some point, but he's busy enough as it is...

[midi-pascal]

Yeah!

Now, hope my fix will be accepted
I am concious that it is a quick fix but not the ideal solution to the problem.
The perfect one would be to have two models for the plugin window: One with the ENV/LFO tab and the m_ssView member for all the plugins and one without them for the MIDI-only things.
But this is a major code change and I'm pretty sure you do not want to go there for now with 1.0.0 soon to be born.
Just to let you know that I am a developer in real life too

Thanks a lot for you very kind help, and I am eager to contribute again and more to the Lmms glory!
Kind regards.

[diiz]

I don't see why it wouldn't be merged, Toby just has to review the request first.